Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropbox: 81.4.195 -> 83.4.152 #72021

Merged
merged 1 commit into from Oct 31, 2019
Merged

dropbox: 81.4.195 -> 83.4.152 #72021

merged 1 commit into from Oct 31, 2019

Conversation

graham33
Copy link
Contributor

@graham33 graham33 commented Oct 26, 2019 •
edited

Motivation for this change

Upgrading to latest stable version per
https://www.dropboxforum.com/t5/Desktop-client-builds/bd-p/101003016.
With the previous nixpkgs version dropbox complained that the version is
too old at sign-in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@graham33
dropbox: 81.4.195 -> 83.4.152
5904be6 
Upgrading to latest stable version per
https://www.dropboxforum.com/t5/Desktop-client-builds/bd-p/101003016.
With the previous nixpkgs version dropbox complained that the version is
too old at sign-in.
@ofborg ofborg bot requested a review from ttuegel October 26, 2019 12:58
@c0bw3b c0bw3b added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 31, 2019
@c0bw3b c0bw3b merged commit 08884d6 into NixOS:master Oct 31, 2019
c0bw3b pushed a commit that referenced this pull request Oct 31, 2019
@graham33 @c0bw3b
dropbox: 81.4.195 -> 83.4.152 (#72021)
c0b8f5d 
Upgrading to latest stable version per
https://www.dropboxforum.com/t5/Desktop-client-builds/bd-p/101003016.
With the previous nixpkgs version dropbox complained that the version is
too old at sign-in.

(cherry picked from commit 08884d6)
@c0bw3b c0bw3b added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 31, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 1, 2019
@graham33 @dtzWill
dropbox: 81.4.195 -> 83.4.152 (NixOS#72021)
02e27d4 
Upgrading to latest stable version per
https://www.dropboxforum.com/t5/Desktop-client-builds/bd-p/101003016.
With the previous nixpkgs version dropbox complained that the version is
too old at sign-in.

(cherry picked from commit 08884d6)
@c0bw3b c0bw3b removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 11, 2019
@graham33 graham33 deleted the fix/dropbox-version-update branch November 18, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@graham33 @bhipple @c0bw3b @Janik-Haag