Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 12.4.0 -> 12.4.1 #72379

Merged
merged 1 commit into from Oct 31, 2019
Merged

gitlab: 12.4.0 -> 12.4.1 #72379

merged 1 commit into from Oct 31, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Oct 31, 2019

Things done
  • Tested basic functionality in a VM
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin @flokli @fpletz @krav

@flokli
Copy link
Contributor

flokli commented Oct 31, 2019

@GrahamcOfBorg test gitlab

@flokli
Copy link
Contributor

flokli commented Oct 31, 2019

Seems the v8 breakage on aarch64 is unrelated to this PR, so merging. Thanks!

@flokli flokli merged commit 2f92bef into NixOS:master Oct 31, 2019
@flokli
Copy link
Contributor

flokli commented Oct 31, 2019

backport PR: #72395

@talyz talyz deleted the gitlab-12.4.1 branch November 4, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @flokli