Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2: 0.27.8 -> 0.28.4 #72544

Merged
merged 3 commits into from Feb 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkgs/development/libraries/git2/default.nix
@@ -1,25 +1,25 @@
{ stdenv, fetchFromGitHub, cmake, pkgconfig, python3
, zlib, libssh2, openssl, http-parser, curl
, zlib, libssh2, openssl, http-parser
, libiconv, Security
}:

stdenv.mkDerivation rec {
pname = "libgit2";
version = "0.27.8";
# keep the version in sync with pythonPackages.pygit2 and libgit2-glib
version = "0.28.4";
# keep the version in sync with python3.pkgs.pygit2 and libgit2-glib

src = fetchFromGitHub {
owner = "libgit2";
repo = "libgit2";
rev = "v${version}";
sha256 = "0wzx8nkyy9m7mx6cks58chjd4289vjsw97mxm9w6f1ggqsfnmbr9";
sha256 = "171b25aym4q88bidc4c76y4l6jmdwifm3q9zjqsll0wjhlkycfy1";
};

cmakeFlags = [ "-DTHREADSAFE=ON" ];

nativeBuildInputs = [ cmake python3 pkgconfig ];

buildInputs = [ zlib libssh2 openssl http-parser curl ]
buildInputs = [ zlib libssh2 openssl http-parser ]
++ stdenv.lib.optional stdenv.isDarwin Security;

propagatedBuildInputs = stdenv.lib.optional (!stdenv.isLinux) libiconv;
Expand Down
28 changes: 19 additions & 9 deletions pkgs/development/python-modules/pygit2/default.nix
@@ -1,25 +1,21 @@
{ stdenv, lib, buildPythonPackage, fetchPypi, fetchpatch, isPyPy, libgit2, six, cffi }:
{ stdenv, lib, buildPythonPackage, fetchPypi, isPyPy, isPy3k, libgit2, pytestCheckHook, cffi, cacert }:

buildPythonPackage rec {
pname = "pygit2";
version = "0.27.2";
version = "1.0.3";

src = fetchPypi {
inherit pname version;
sha256 = "0d9bgxd6ch5jxz0j5cmx7c4kw933g8pgm2zxf3id1a6w9g2r7hpw";
sha256 = "1ql7hkcxrh8yszglrg7d3y0ivh1l56xdc3j34j2fjy4qq06ifv6y";
};

preConfigure = lib.optionalString stdenv.isDarwin ''
export DYLD_LIBRARY_PATH="${libgit2}/lib"
'';

patches = [ (fetchpatch {
name = "dont-require-old-pycparser"; # https://github.com/libgit2/pygit2/issues/819
url = https://github.com/libgit2/pygit2/commit/1eaba181577de206d3d43ec7886d0353fc0c9f2a.patch;
sha256 = "18x1fpmywhjjr4lvakwmy34zpxfqi8pqqj48g1wcib39lh3s7l4f";
}) ];
propagatedBuildInputs = [ libgit2 ] ++ lib.optional (!isPyPy) cffi;

propagatedBuildInputs = [ libgit2 six ] ++ lib.optional (!isPyPy) cffi;
checkInputs = [ pytestCheckHook ];

preCheck = ''
# disable tests that require networking
Expand All @@ -28,6 +24,20 @@ buildPythonPackage rec {
rm test/test_submodule.py
'';

# Tests require certificates
# https://github.com/NixOS/nixpkgs/pull/72544#issuecomment-582674047
SSL_CERT_FILE = "${cacert}/etc/ssl/certs/ca-bundle.crt";

# setup.py check is broken
# https://github.com/libgit2/pygit2/issues/868
dontUseSetuptoolsCheck = true;

# TODO: Test collection is failing
# https://github.com/NixOS/nixpkgs/pull/72544#issuecomment-582681068
doCheck = false;

disabled = !isPy3k;

meta = with lib; {
description = "A set of Python bindings to the libgit2 shared library";
homepage = https://pypi.python.org/pypi/pygit2;
Expand Down
8 changes: 4 additions & 4 deletions pkgs/tools/filesystems/gitfs/default.nix
@@ -1,6 +1,6 @@
{ stdenv, fetchFromGitHub, python2Packages }:
{ stdenv, fetchFromGitHub, python3Packages }:

python2Packages.buildPythonApplication rec {
python3Packages.buildPythonApplication rec {
pname = "gitfs";
version = "0.5.2";

Expand All @@ -16,8 +16,8 @@ python2Packages.buildPythonApplication rec {
echo > requirements.txt
'';

buildInputs = with python2Packages; [ pytest pytestcov mock ];
propagatedBuildInputs = with python2Packages; [ atomiclong fusepy pygit2 ];
checkInputs = with python3Packages; [ pytest pytestcov mock ];
propagatedBuildInputs = with python3Packages; [ atomiclong fusepy pygit2 six ];

checkPhase = "py.test";
doCheck = false;
Expand Down