Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests: port some tests to python (loki, grafana, pgjwt, initrd-ssh, exporters) #72904

Merged
merged 5 commits into from Nov 7, 2019

Conversation

@WilliButz
Copy link
Member

WilliButz commented Nov 6, 2019

Things done

Migrated most of the tests I maintain from the perl driver to python.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc #72828

@ofborg ofborg bot added the 6.topic: nixos label Nov 6, 2019
@WilliButz

This comment has been minimized.

Copy link
Member Author

WilliButz commented Nov 6, 2019

@GrahamcOfBorg test loki pgjwt initrd-network-ssh grafana

@WilliButz

This comment has been minimized.

Copy link
Member Author

WilliButz commented Nov 6, 2019

the test driver for grafana failed on x86_64:

Fatal Python error: could not acquire lock for <_io.BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threads

Thread 0x00007ffff5ac1700 (most recent call first):
  File "/nix/store/a1x3rkfv5af5wpsinwy6bnhwqgdiry4b-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 85 in eprint
  File "/nix/store/a1x3rkfv5af5wpsinwy6bnhwqgdiry4b-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 601 in process_serial_output
Thread 0x00007ffff62c2700 (most recent call first):
  File "/nix/store/a1x3rkfv5af5wpsinwy6bnhwqgdiry4b-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 85 in eprint
  File "/nix/store/a1x3rkfv5af5wpsinwy6bnhwqgdiry4b-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 601 in process_serial_output
Current thread 0x00007ffff7650b80 (most recent call first):
/nix/store/kirg08m7yzlp226q7ki61q9j5zjf1x9p-stdenv-linux/setup: line 1293:     6 Aborted                 LOGFILE=$out/log.xml tests='exec(os.environ["testScript"])' /nix/store/i8r4vhyp3c1mn3rgjgzghfmwdmd8y40f-nixos-test-driver-grafana/bin/nixos-test-driver
builder for '/nix/store/s0z4b92i2665czxl4mqq10g9ws4ddi8c-vm-test-run-grafana.drv' failed with exit code 134

@GrahamcOfBorg test grafana

nixos/tests/grafana.nix Outdated Show resolved Hide resolved
WilliButz added 5 commits Nov 6, 2019
@WilliButz WilliButz force-pushed the WilliButz:nixosTests/port-to-python branch from 9685c96 to 426b467 Nov 7, 2019
@WilliButz

This comment has been minimized.

Copy link
Member Author

WilliButz commented Nov 7, 2019

@tfc updated the subtest descriptions for the grafana test and rebased onto master :)

@tfc
tfc approved these changes Nov 7, 2019
@WilliButz WilliButz merged commit d7b18bc into NixOS:master Nov 7, 2019
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@WilliButz WilliButz deleted the WilliButz:nixosTests/port-to-python branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.