Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: Fix cross after I accidentally changed build target for 19.09 #73185

Merged
merged 1 commit into from Nov 10, 2019
Merged

gcc: Fix cross after I accidentally changed build target for 19.09 #73185

merged 1 commit into from Nov 10, 2019

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Nov 10, 2019 •
edited

Motivation for this change

backport of #73184

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ericson2314
gcc: Fix cross after I accidentally changed build target
3f74a4d 
I deleted "bootstrap", but forgot to make the condition
build = host = target.
@Ericson2314 Ericson2314 changed the title gcc: Fix cross after I accidentally changed build target gcc: Fix cross after I accidentally changed build target for 19.09 Nov 10, 2019
@Ericson2314 Ericson2314 merged commit 8ce730d into NixOS:release-19.09 Nov 10, 2019
@Ericson2314 Ericson2314 deleted the gcc-fix-cross-whoops branch November 13, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer matthewbauer is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ericson2314