Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r19.09] samba: 4.10.8 -> 4.10.10, addressing CVE-2019-10218, CVE-2019-14833 & CVE-2019-14847 #73366

Closed

Conversation

@risicle
Copy link
Contributor

risicle commented Nov 13, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-10218
https://nvd.nist.gov/vuln/detail/CVE-2019-14833
https://nvd.nist.gov/vuln/detail/CVE-2019-14847

See #73315 for master.

Again, I would appreciate testing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

addressing CVE-2019-10218, CVE-2019-14833 & CVE-2019-14847
@risicle

This comment has been minimized.

Copy link
Contributor Author

risicle commented Nov 13, 2019

@GrahamcOfBorg test samba
@GrahamcOfBorg build samba samba4Full gvfs

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Nov 17, 2019

@GrahamcOfBorg test samba

@d-goldin

This comment has been minimized.

Copy link
Contributor

d-goldin commented Nov 19, 2019

Sorry, I missed this PR when looking at the vulnix issue (#73754).

@d-goldin d-goldin mentioned this pull request Nov 19, 2019
4 of 10 tasks complete
@ckauhaus

This comment has been minimized.

Copy link
Contributor

ckauhaus commented Nov 19, 2019

@risicle The PR got superseded by #73761. Sorry for the long delay while reviewing PRs and the resulting confusion...

@ckauhaus ckauhaus closed this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.