Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/ksm: Enhancements and new ksmtuned package. #73823

Open
wants to merge 3 commits into
base: master
from

Conversation

@kmcopper
Copy link
Contributor

kmcopper commented Nov 20, 2019

Motivation for this change

#73095 partially gave me the idea to work on this patch set to help unload udev-settle. I worked some additional enhancements to the ksm configuration while I was at it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

There aren't really any of these for ksm but I would appreciate anybodies input on this

kmcopper added 3 commits Nov 20, 2019
adds an option to nix configuration that allows ksm zero pages to be
toggleable.
This patch adds ksmtuned and a corresponding service unit.
@kmcopper kmcopper marked this pull request as ready for review Nov 20, 2019
@kmcopper kmcopper requested a review from Infinisil as a code owner Nov 20, 2019
@kmcopper

This comment has been minimized.

Copy link
Contributor Author

kmcopper commented Nov 20, 2019

Oops, looks like my maintainer attribute is tied up in #53032 and that's why the check fails here vs when I tested it.

@kmcopper

This comment has been minimized.

Copy link
Contributor Author

kmcopper commented Nov 30, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build ksmtuned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.