Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.xdis: Add magics for current python versions #74706

Closed
wants to merge 1 commit into from

Conversation

@ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 29, 2019

Motivation for this change

Fixes https://hydra.nixos.org/build/106234032 and https://hydra.nixos.org/build/106228382

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ahiaao ahiaao requested a review from FRidh as a code owner Nov 29, 2019
@ahiaao ahiaao force-pushed the ahiaao:fix/xdis-python375 branch from 66f3b35 to 170a383 Nov 29, 2019
@ofborg ofborg bot added the 6.topic: python label Nov 29, 2019
@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 29, 2019

I wonder why the package cares for versioning outside of major.minor... seems like they are trying to control things out of reach

@marsam
Copy link
Contributor

@marsam marsam commented Dec 9, 2019

I've backported the last xdis updates to 19:09 8e6bf26

@marsam marsam closed this Dec 9, 2019
@ahiaao ahiaao deleted the ahiaao:fix/xdis-python375 branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.