Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsf2flac: init at 0.1Rev54 #74845

Merged
merged 1 commit into from Nov 28, 2020
Merged

dsf2flac: init at 0.1Rev54 #74845

merged 1 commit into from Nov 28, 2020

Conversation

dmrauh
Copy link
Contributor

@dmrauh dmrauh commented Dec 2, 2019

Motivation for this change

I needed a tool to transcode audio files from DSD to FLAC and dsf2flac was not part of nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dpaetzel
Copy link
Contributor

dpaetzel commented Dec 4, 2019 •
edited

Thank you for the PR! I tried it out using nix-review and everything works as far as i can tell (I successfully converted a DSD file to FLAC).

@dmrauh
Copy link
Contributor Author

dmrauh commented Dec 5, 2019

That's good to hear! Thanks for testing!

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@dmrauh
Copy link
Contributor Author

dmrauh commented Jun 2, 2020 •
edited

This PR is still important to me. I would be very glad if someone would merge it 😃

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@dmrauh dmrauh requested review from jonringer and FRidh June 2, 2020 14:25
jonringer
jonringer reviewed Jun 2, 2020
View reviewed changes
pkgs/applications/audio/dsf2flac/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/dsf2flac/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/dsf2flac/default.nix Outdated Show resolved Hide resolved
@dmrauh dmrauh force-pushed the add/dsf2flac branch 3 times, most recently from 6bc144b to 7876fd7 Compare June 3, 2020 07:22
@dmrauh
Copy link
Contributor Author

dmrauh commented Jun 3, 2020

Thanks @jonringer for your review! I changed the package definition according to your suggestions.

@dmrauh
Copy link
Contributor Author

dmrauh commented Jun 3, 2020

Shame on me for not reading the nixpkgs manual properly! Thanks for spotting!

@dmrauh dmrauh requested a review from jonringer June 5, 2020 08:15
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/188

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 74845 run on x86_64-linux 1

1 package built:
  • dsf2flac

@SuperSandro2000 SuperSandro2000 merged commit cee92cf into NixOS:master Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmrauh @dpaetzel @nixos-discourse @SuperSandro2000 @jonringer