Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsf2flac: init at 0.1Rev54 #74845

Open
wants to merge 1 commit into
base: master
from
Open

dsf2flac: init at 0.1Rev54 #74845

wants to merge 1 commit into from

Conversation

@dmrauh
Copy link
Contributor

dmrauh commented Dec 2, 2019

Motivation for this change

I needed a tool to transcode audio files from DSD to FLAC and dsf2flac was not part of nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dpaetzel

This comment has been minimized.

Copy link
Contributor

dpaetzel commented Dec 4, 2019

Thank you for the PR! I tried it out using nix-review and everything works as far as i can tell (I successfully converted a DSD file to FLAC).

@dmrauh

This comment has been minimized.

Copy link
Contributor Author

dmrauh commented Dec 5, 2019

That's good to hear! Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.