Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.[open]ldap: port to python #74851

Merged
merged 2 commits into from Dec 4, 2019
Merged

Conversation

@tfc
Copy link
Contributor

tfc commented Dec 2, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli @worldofpeace @Lassulus

@tfc

This comment has been minimized.

Copy link
Contributor Author

tfc commented Dec 2, 2019

@GrahamcOfBorg test ldap openldap

Copy link
Contributor

Lassulus left a comment

LGTM

@flokli flokli changed the title Nixos test ldap python nixosTests.[open]ldap: port to python Dec 2, 2019
@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Dec 2, 2019

Can you update the two commit messages to start with nixosTests.ldap / nixosTests.openldap?

@tfc

This comment has been minimized.

Copy link
Contributor Author

tfc commented Dec 3, 2019

Can you update the two commit messages to start with nixosTests.ldap / nixosTests.openldap?

the contributing guide says it would be nixos/ldap: msg and nixos/openldap: msg. Where does the new requirement come from?

(pkg-name | nixos/<module>): (from -> to | init at version | refactor | etc)

(Motivation for change. Additional information.)
@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Dec 4, 2019

You're working on the tests, not the [open]ldap modules. The tests are exposed under the nixosTests.[open]ldap attribute.

@tfc tfc force-pushed the tfc:nixos-test-ldap-python branch from 297d5c8 to 5d91b29 Dec 4, 2019
@tfc

This comment has been minimized.

Copy link
Contributor Author

tfc commented Dec 4, 2019

@flokli done

@flokli

This comment has been minimized.

Copy link
Contributor

flokli commented Dec 4, 2019

@GrahamcOfBorg test openldap ldap

@flokli flokli merged commit afd8bb3 into NixOS:master Dec 4, 2019
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.ldap, tests.openldap on aarch64-linux Success
Details
tests.ldap, tests.openldap on x86_64-linux Success
Details
@tfc tfc deleted the tfc:nixos-test-ldap-python branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.