-
-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixosTests.[open]ldap: port to python #74851
Conversation
@GrahamcOfBorg test ldap openldap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you update the two commit messages to start with |
the contributing guide says it would be
|
You're working on the tests, not the [open]ldap modules. The tests are exposed under the |
297d5c8
to
5d91b29
Compare
@flokli done |
@GrahamcOfBorg test openldap ldap |
Motivation for this change
#72828
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @flokli @worldofpeace @Lassulus