Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmh: init at 0.4 #75312

Merged
merged 2 commits into from Mar 14, 2020
Merged

mmh: init at 0.4 #75312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4481a20
maintainers: add KAction
KAction Dec 8, 2019
b1c71eb
mmh-unstable: init at 2019-09-08
KAction Dec 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions maintainers/maintainer-list.nix
View file
Open in desktop
Expand Up @@ -3698,6 +3698,16 @@
githubId = 66669;
name = "Jeff Zellner";
};
kaction = {
name = "Dmitry Bogatov";
email = "KAction@disroot.org";
github = "kaction";
githubId = 44864956;
key = [{
longkeyid = "ed25519/0x749FD4DFA2E94236";
fingerprint = "3F87 0A7C A7B4 3731 2F13 6083 749F D4DF A2E9 4236";
}];
};
kaiha = {
email = "kai.harries@gmail.com";
github = "kaiha";
Expand Down
24 changes: 24 additions & 0 deletions pkgs/applications/networking/mailreaders/mmh/default.nix
View file
Open in desktop
@@ -0,0 +1,24 @@
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continuing from @alyssais 's comment,

Suggested change
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:

Personally, I prefer:

Suggested change
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:
{ stdenv
, fetchurl
, ncurses
, autoreconfHook
, flex
}:

With this ^, diffs look much better if dependencies are changed.

let rev = "431604647f89d5aac7b199a7883e98e56e4ccf9e";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To put my 2 cents, I prefer to not use a let-in for such a trivial variable, so I'd just put it straight in src. Moreover, Although their git server is slow, I'd use fetchgit never the less. 1 example of an advantage to that is that It'll be easier to switch to a different git server if fetchgit is used. It's also possible that in the future all derivations with sources using fetchgit, will be automatically updated once a new tag was set. There are plans for making our main updater bot @r-ryantm do that.

in stdenv.mkDerivation rec {
pname = "mmh-unstable";
version = "2019-09-08";

src = fetchurl {
url = "http://git.marmaro.de/?p=mmh;a=snapshot;h=${rev};sf=tgz";
name = "mmh-${rev}.tgz";
sha256 = "1q97p4g3f1q2m567i2dbx7mm7ixw3g91ww2rymwj42cxk9iyizhv";
};

buildInputs = [ ncurses ];
nativeBuildInputs = [ autoreconfHook flex ];

meta = with stdenv.lib; {
description = "Set of electronic mail handling programs";
homepage = "http://marmaro.de/prog/mmh";
license = licenses.bsd3;
platforms = platforms.unix;
broken = stdenv.isDarwin;
maintainers = with maintainers; [ kaction ];
};
}
1 change: 1 addition & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Expand Up @@ -20588,6 +20588,7 @@ in
else
libsForQt5.callPackage ../applications/audio/musescore { };

mmh = callPackage ../applications/networking/mailreaders/mmh { };
mutt = callPackage ../applications/networking/mailreaders/mutt { };
mutt-with-sidebar = mutt.override {
withSidebar = true;
Expand Down