Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.quick-scope: init at 2019-04-22 #75595

Merged
merged 3 commits into from Dec 13, 2019

Conversation

@lovesegfault
Copy link
Contributor

@lovesegfault lovesegfault commented Dec 13, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonringer

@lovesegfault lovesegfault requested a review from jonringer as a code owner Dec 13, 2019
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Dec 13, 2019

[105 built, 33 copied (814.4 MiB), 187.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75595
55 package were built:
vimPlugins.UltiSnips vimPlugins.agda-vim vimPlugins.airline vimPlugins.calendar vimPlugins.coc-lists vimPlugins.coc-nvim vimPlugins.coc-pairs vimPlugins.coc-rls vimPlugins.coc-snippets vimPlugins.coc-tabnine vimPlugins.coc-tsserver vimPlugins.coc-yank vimPlugins.csv vimPlugins.denite vimPlugins.deoplete-fish vimPlugins.deoplete-jedi vimPlugins.deoplete-lsp vimPlugins.deoplete-nvim vimPlugins.dhall-vim vimPlugins.echodoc vimPlugins.editorconfig-vim vimPlugins.falcon vimPlugins.fugitive vimPlugins.gentoo-syntax vimPlugins.gv-vim vimPlugins.jedi-vim vimPlugins.lightline-vim vimPlugins.ncm2-ultisnips vimPlugins.neosnippet vimPlugins.neoterm vimPlugins.neoyank-vim vimPlugins.polyglot vimPlugins.quick-scope vimPlugins.quickfix-reflector-vim vimPlugins.seoul256-vim vimPlugins.table-mode vimPlugins.targets-vim vimPlugins.tmuxNavigator vimPlugins.vim-airline-themes vimPlugins.vim-flagship vimPlugins.vim-go vimPlugins.vim-grepper vimPlugins.vim-jsx-pretty vimPlugins.vim-mucomplete vimPlugins.vim-orgmode vimPlugins.vim-peekaboo vimPlugins.vim-pencil vimPlugins.vim-plug vimPlugins.vim-ruby vimPlugins.vim-slime vimPlugins.vim-snippets vimPlugins.vim-tmux-focus-events vimPlugins.vim-trailing-whitespace vimPlugins.vimtex vimPlugins.zig-vim
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 13, 2019

looks like your first commit is kind of messed up. please do the update first, then add each individual plugin as a separate commit :)

@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Dec 13, 2019

@jonringer it looks fine to me? I noticed the plugin list was out of order and fixed it, making that its own commit. Second commit is version bumps, and lastly the added plugin.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 13, 2019

oh, i got hung up on the sort commit. LGTM, ty for fixing that

Copy link
Contributor

@jonringer jonringer left a comment

commits LGTM
diff LGTM

[109 built, 28 copied (413.6 MiB), 91.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75595
55 package were built:
vimPlugins.agda-vim vimPlugins.calendar-vim vimPlugins.coc-lists vimPlugins.coc-nvim vimPlugins.coc-pairs vimPlugins.coc-rls vimPlugins.coc-snippets vimPlugins.coc-tabnine vimPlugins.coc-tsserver vimPlugins.coc-yank vimPlugins.csv-vim vimPlugins.denite-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-jedi vimPlugins.deoplete-lsp vimPlugins.deoplete-nvim vimPlugins.dhall-vim vimPlugins.echodoc-vim vimPlugins.editorconfig-vim vimPlugins.falcon vimPlugins.gentoo-syntax vimPlugins.gv-vim vimPlugins.jedi-vim vimPlugins.lightline-vim vimPlugins.ncm2-ultisnips vimPlugins.neosnippet-vim vimPlugins.neoterm vimPlugins.neoyank-vim vimPlugins.quick-scope vimPlugins.quickfix-reflector-vim vimPlugins.seoul256-vim vimPlugins.targets-vim vimPlugins.ultisnips vimPlugins.vim-airline vimPlugins.vim-airline-themes vimPlugins.vim-flagship vimPlugins.vim-fugitive vimPlugins.vim-go vimPlugins.vim-grepper vimPlugins.vim-jsx-pretty vimPlugins.vim-mucomplete vimPlugins.vim-orgmode vimPlugins.vim-peekaboo vimPlugins.vim-pencil vimPlugins.vim-plug vimPlugins.vim-polyglot vimPlugins.vim-ruby vimPlugins.vim-slime vimPlugins.vim-snippets vimPlugins.vim-table-mode vimPlugins.vim-tmux-focus-events vimPlugins.vim-tmux-navigator vimPlugins.vim-trailing-whitespace vimPlugins.vimtex vimPlugins.zig-vim
@jonringer jonringer merged commit 6f66fad into NixOS:master Dec 13, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vimPlugins.quick-scope on aarch64-linux Success
Details
vimPlugins.quick-scope on x86_64-linux Success
Details
@lovesegfault lovesegfault deleted the lovesegfault:vimPlugins-quick-scope branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.