Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gobuster: init at 3.0.1 #75902

Merged
merged 1 commit into from Dec 20, 2019
Merged

gobuster: init at 3.0.1 #75902

merged 1 commit into from Dec 20, 2019

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

Make gobuster available via Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit December 18, 2019 22:33
jonringer
jonringer approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM (1 minor suggestion)
commits LGTM
executable shows usage

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75902
1 package were built:
gobuster

pkgs/tools/security/gobuster/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit December 19, 2019 18:08
@kalbasit
Copy link
Member

@GrahamcOfBorg build gobuster

@kalbasit kalbasit merged commit b76720f into NixOS:master Dec 20, 2019
@Pamplemousse Pamplemousse deleted the gobuster branch August 7, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pamplemousse @kalbasit @jonringer