Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu: 4.1.0 -> 4.2.0, including patch for minor CVE-2019-15890 #76065

Merged
merged 2 commits into from Jan 2, 2020

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Dec 19, 2019

Motivation for this change

Mostly the bump but also https://nvd.nist.gov/vuln/detail/CVE-2019-15890

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle
Copy link
Contributor Author

@risicle risicle commented Dec 19, 2019

@GrahamcOfBorg build aqemu vagrant minikube cloud-utils

@blitz
Copy link
Contributor

@blitz blitz commented Dec 26, 2019

I gave this a quick shot. Looks good.

Testing done

  • Booting grml LiveCD with qemu-system-x86_64
  • Booting RISC-V kernel in qemu-system-riscv64
@wedens
Copy link

@wedens wedens commented Dec 30, 2019

Unfortunately, qemu is already updated to 4.1 in unstable, but libvirt is still 5.4.0. so I'll mention it here.

Using some vpindex hyper-v enlightement with qemu > 4.0 and libvirt < 5.6.0 will result in this error:

"error: unsupported configuration: host doesn't support hyperv 'vpindex' feature"

Many other enlightements depend on vpindex presence.

It probably worth its own issue, but I just want to bring attention.

https://www.redhat.com/archives/libvir-list/2019-July/msg01642.html

@fpletz fpletz merged commit 5338dd7 into NixOS:master Jan 2, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
aqemu, cloud-utils, minikube, vagrant on aarch64-linux Success
Details
aqemu, cloud-utils, minikube, vagrant on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
qemu on aarch64-linux Success
Details
qemu on x86_64-linux Success
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 18, 2020
qemu: 4.1.0 -> 4.2.0, including patch for minor CVE-2019-15890
(cherry picked from commit 5338dd7)
@zowoq zowoq mentioned this pull request Oct 24, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.