Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handbrake: 1.2.2 -> 1.3.0 #76112

Merged
merged 2 commits into from Dec 22, 2019
Merged

handbrake: 1.2.2 -> 1.3.0 #76112

merged 2 commits into from Dec 22, 2019

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Dec 20, 2019

This update is important as handbrake 1.2.2 no longer builds with
nixpkgs due to an unrelated update to pango-1.44.x as described
here.

Fixes #73399

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@acowley
Copy link
Contributor Author

acowley commented Dec 20, 2019

Thanks to @jtojnar for showing the way forward with this comment.

@acowley
Copy link
Contributor Author

acowley commented Dec 21, 2019

I've done things differently to possibly better insulate our changes to the upstream build.

@acowley acowley force-pushed the handbrake-1.3.0 branch 2 times, most recently from 3afde0e to 2c5cebb Compare December 21, 2019 01:24
@acowley
handbrake: 1.2.2 -> 1.3.0
b4dea13 
This update is important as handbrake 1.2.2 no longer builds with
nixpkgs due to an unrelated update to pango-1.44.x as described
[here](HandBrake/HandBrake#2226).

Fixes NixOS#73399
@acowley
handbrake: remove nasm and cmake dependencies
7978601 
These were included by the handbrake build because they are used by external dependencies. In nixpkgs, we build those dependencies (e.g. codecs) separately, and so excise the check for these tools from the handbrake build.
jtojnar
jtojnar approved these changes Dec 21, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, program starts.

Lassulus
Lassulus approved these changes Dec 22, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, seems to work, weird behavior when I try to open files

@Lassulus Lassulus merged commit c729a06 into NixOS:master Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@jtojnar jtojnar jtojnar approved these changes

@wmertens wmertens Awaiting requested review from wmertens

@Anton-Latukha Anton-Latukha Awaiting requested review from Anton-Latukha

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handbrake: problems updating to 1.3.0
3 participants
@acowley @Lassulus @jtojnar