Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.kexec: port to python and mark as broken #76560

Merged
merged 1 commit into from Jan 1, 2020

Conversation

@nh2
Copy link
Contributor

@nh2 nh2 commented Dec 27, 2019

Motivation for this change

#72828

WIP Marking as broken because the test did not succeed for me before this commit (the Perl test hung forever), and this translation exhibits the same problem.

Maybe anyone knows more?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 27, 2019

We don't have to fix every test in the port, you can mark it as broken.

The test did not succeed for me before this commit
(the Perl test hung forever), and this translation exhibits
the same problem.
@nh2 nh2 force-pushed the nh2:kexec-test-python branch from a1e1306 to 12e3503 Dec 27, 2019
@nh2
Copy link
Contributor Author

@nh2 nh2 commented Dec 27, 2019

you can mark it as broken.

OK, added comment and removing WIP.

@nh2 nh2 changed the title [WIP] nixosTests.kexec: port to python. nixosTests.kexec: port to python and mark as broken Dec 27, 2019
@nh2
Copy link
Contributor Author

@nh2 nh2 commented Dec 27, 2019

Trying anyway:

@GrahamcOfBorg test kexec

@flokli flokli merged commit 2393fa2 into NixOS:master Jan 1, 2020
14 checks passed
14 checks passed
tests.kexec on aarch64-linux No attempt
Details
tests.kexec on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.