Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom, atom-beta: 1.36.1 -> 1.42.0, 1.37.0-beta0 -> 1.43.0-beta0 #76716

Merged
merged 1 commit into from Jan 1, 2020

Conversation

@ysndr
Copy link
Contributor

@ysndr ysndr commented Dec 30, 2019

Motivation for this change

Closes: #75183

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @offlinehacker @NeQuissimus @ysndr

@veprbl
Copy link
Member

@veprbl veprbl commented Dec 30, 2019

@GrahamcOfBorg build atom atom-beta

@NeQuissimus
Copy link
Member

@NeQuissimus NeQuissimus commented Dec 30, 2019

I cannot run either of these:

/nix/store/rmpm5cq44v4fjj6kwgnczcaksy8gqh65-atom-1.42.0/share/atom/atom: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory
Add shared libraries libuuid and libatk-bridge
@ysndr ysndr force-pushed the ysndr:review/atom140 branch from 1c126c1 to 9922a54 Dec 31, 2019
@ysndr
Copy link
Contributor Author

@ysndr ysndr commented Dec 31, 2019

My bad, I did not specifically run this in a pure shell so this and another shared lib were already present.
Should be fixed now though

@ysndr
Copy link
Contributor Author

@ysndr ysndr commented Dec 31, 2019

@GrahamcOfBorg build atom atom-beta

@NeQuissimus NeQuissimus merged commit 8d39a23 into NixOS:master Jan 1, 2020
15 checks passed
15 checks passed
atom, atom-beta on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
atom, atom-beta on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.