minetest: update to 5.1.0 and build on Darwin #77967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
|
Usually we put the macOS versions into the same file, to avoid duplication (and use conditionals inside the file). Is this not an option here? |
|
For irrlicht, I wasn't able to get the build system based on Xcode to work so I found another one based on cmake. Therefore it's quite different in the end. |
LnL7
reviewed
Feb 1, 2020
| for file in out-shared/*.dylib*; do | ||
| install_name_tool -id $out/lib/$file $file | ||
| for file in out-shared/*.dylib.*.*; do | ||
| install_name_tool -id $out/lib/$(basename $file) $file |
There was a problem hiding this comment.
We have a fixDarwinDylibNames helper for projects that don't set the install name correctly.
| let | ||
| version = "1.8.4"; | ||
|
|
||
| irrlichtZip = fetchzip { |
There was a problem hiding this comment.
It would be better to reuse the source from default.nix so the versions can't get out of sync.
|
Yes, done on my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Build minetest and irrlicht on Darwin.
Update minetest to 5.1.0
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)