Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lispPackages: add serapeum #78146

Merged
merged 1 commit into from Jan 30, 2020
Merged

lispPackages: add serapeum #78146

merged 1 commit into from Jan 30, 2020

Conversation

tviti
Copy link
Contributor

@tviti tviti commented Jan 21, 2020

Adds common-lisp package serapeum (a dependency for Next browser as of
Next v1.4.0), using the quicklisp-to-nix mechanism.

src is overridden and pinned to 65837f8 to deal with
ruricolist/serapeum#42

Motivation for this change

Permits updating nixpkgs.next to >= v1.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tviti
lispPackages: add serapeum
418b80b 
Adds common-lisp package serapeum (a dependency for Next browser as of
Next v1.4.0), using the quicklisp-to-nix mechanism.

src is overridden and pinned to 65837f8 to deal with
ruricolist/serapeum#42
@tviti
Copy link
Contributor Author

tviti commented Jan 21, 2020

Maybe I should add: I have my own derivation that installs Next from a personal-use fork, that builds against this OK.

@bqv
Copy link
Contributor

bqv commented Jan 30, 2020

+1 !

@jmercouris
Copy link

Is there anything preventing this from being merged?

@7c6f434c 7c6f434c merged commit 8b3f9cd into NixOS:master Jan 30, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@7c6f434c @anna328p
Merge pull request NixOS#78146 from tviti/serapeum
66375c7 
lispPackages: add serapeum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tviti @bqv @jmercouris @7c6f434c @Janik-Haag