Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lobster: init at unstable-2020-01-22 #78562

Merged
merged 1 commit into from Sep 23, 2020
Merged

lobster: init at unstable-2020-01-22 #78562

merged 1 commit into from Sep 23, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jan 26, 2020 •
edited

Motivation for this change

I picked the darwin bits from #59128.
Could someone please trigger a darwin build? not sure if this is still relevant:
1e8d9c2#diff-d82c125fb3539f785cdbfe6eec27d90dR20-R27

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Closes #59128

@fgaz fgaz mentioned this pull request Jan 26, 2020
Closed
10 tasks
@fgaz fgaz mentioned this pull request Jan 26, 2020
Merged
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build lobster

@fgaz
Copy link
Member Author

fgaz commented Feb 4, 2020 •
edited

lobster on x86_64-darwin — No attempt

well duh... I put platforms = linux 🤦‍♂️

Let's try now

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build lobster

worldofpeace
worldofpeace reviewed Feb 4, 2020
View reviewed changes
pkgs/development/compilers/lobster/default.nix
enableParallelBuilding = true;

meta = with stdenv.lib; {
homepage = "http://strlen.com/lobster";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is https https://aardappel.github.io/lobster/README_FIRST.html, but links to this site too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying that I should use that url for homepage? Shouldn't it be the canonical one?

@fgaz
Copy link
Member Author

fgaz commented Jul 29, 2020

Rebased, updated, added a test
ping @worldofpeace

@ryantm
Copy link
Member

ryantm commented Sep 23, 2020

Result of nixpkgs-review pr 78562 1

1 package built:
- lobster

@ryantm ryantm merged commit cc7d3ff into NixOS:master Sep 23, 2020
@fgaz fgaz deleted the lobster/init branch September 23, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @worldofpeace @ryantm