Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-helm: 3.0.1 -> 3.0.3 and improve build meta #78796

Merged
merged 2 commits into from Feb 1, 2020

Conversation

@Frostman
Copy link
Member

@Frostman Frostman commented Jan 30, 2020

Motivation for this change

Update K8s Helm to the latest version. Both 3.0.2 and 3.0.3 are patch releases with some important fixes. Additionally, I'd like to add myself to maintainers as I'm using it quite extensively and can help to keep its package up to date and supported.

https://github.com/helm/helm/releases/tag/v3.0.2
https://github.com/helm/helm/releases/tag/v3.0.3

Fix to ldflags is needed to get correct helm version output:

$ helm version
version.BuildInfo{Version:"v3.0.3", GitCommit:"", GitTreeState:"", GoVersion:"go1.13.6"}
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

Copy link
Member

@saschagrunert saschagrunert left a comment

LGTM

Copy link
Contributor

@edude03 edude03 left a comment

👍 looks good to me

@kalbasit
Copy link
Member

@kalbasit kalbasit commented Jan 30, 2020

@GrahamcOfBorg build helm

@kalbasit
Copy link
Member

@kalbasit kalbasit commented Jan 30, 2020

The package is actually called kubernetes-helm so the PR title/commit must be updated to reflect that.

@GrahamcOfBorg build kubernetes-helm

@Frostman Frostman changed the title helm: 3.0.1 -> 3.0.3 and improve build meta kubernetes-helm: 3.0.1 -> 3.0.3 and improve build meta Jan 30, 2020
@Frostman
Copy link
Member Author

@Frostman Frostman commented Jan 30, 2020

@kalbasit thx for the review. Fixed title and dropped goPackagePath from legacy go support.

@Frostman Frostman requested a review from kalbasit Jan 30, 2020
@ofborg ofborg bot requested review from edude03 and saschagrunert Jan 31, 2020
@kalbasit
Copy link
Member

@kalbasit kalbasit commented Jan 31, 2020

@Frostman looks good. Do you mind updating the commit message of e25233c as well.

Frostman and others added 2 commits Jan 30, 2020
@Frostman Frostman force-pushed the Frostman:helm-3.0.3 branch from 16908a8 to 6f2523e Feb 1, 2020
@Frostman
Copy link
Member Author

@Frostman Frostman commented Feb 1, 2020

@kalbasit done, thx for reviews

@ofborg ofborg bot requested a review from saschagrunert Feb 1, 2020
@kalbasit
Copy link
Member

@kalbasit kalbasit commented Feb 1, 2020

@GrahamcOfBorg build kubernetes-helm

@kalbasit kalbasit merged commit 65e6812 into NixOS:master Feb 1, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kubernetes-helm on aarch64-linux Success
Details
kubernetes-helm on x86_64-darwin Success
Details
kubernetes-helm on x86_64-linux Success
Details
@Frostman Frostman deleted the Frostman:helm-3.0.3 branch Feb 1, 2020
anna328p added a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
kubernetes-helm: 3.0.1 -> 3.0.3 and improve build meta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.