Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector: 0.7.1 -> 0.7.2 #79224

Closed
wants to merge 1 commit into from
Closed

vector: 0.7.1 -> 0.7.2 #79224

wants to merge 1 commit into from

Conversation

@a-rodin
Copy link
Contributor

@a-rodin a-rodin commented Feb 4, 2020

Motivation for this change

This PR updates Vector to version 0.7.2. It also enables the tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@nlewo nlewo left a comment

The test fails on ofborg (the build bot). Could you take a look?

@thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Feb 11, 2020

Sorry for leaving this around -- yes, looks like a strange test failure. Maybe something to do with parallelism (complete speculation)? Either way, if we could get the tests enabled, that would be great!

@a-rodin
Copy link
Contributor Author

@a-rodin a-rodin commented Feb 12, 2020

@thoughtpolice It turns out that all tests failures are caused by the fact that checkPhase runs in an environment which doesn't have file /etc/resolve.conf (and it was present when the tests were running inside a Docker container with official NixOS image, which made the issue uncaught). This file path is hardcoded in rust-dns-resolver which Vector uses.

I wonder is there a way to have file /etc/resolv.conf in the test environment.

@a-rodin
Copy link
Contributor Author

@a-rodin a-rodin commented Feb 25, 2020

Superseded by #81040.

@a-rodin a-rodin closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.