Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.python-pam: init at 1.8.4 #79274

Closed
wants to merge 1 commit into from

Conversation

@arnoldfarkas
Copy link
Contributor

@arnoldfarkas arnoldfarkas commented Feb 5, 2020

Motivation for this change

Packaging Python module python-pam in Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

otherwise LGTM


# there is no test code for this module
doCheck = false;

This comment has been minimized.

@jonringer

jonringer Feb 17, 2020
Contributor

in lieu of tests, please at least do

Suggested change
pythonImportsCheck = [ "pam" ];
};

# ctypes.util.find_library does not work on Nix
patchPhase = ''

This comment has been minimized.

@FRidh

FRidh Feb 17, 2020
Member

postPatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.