Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corerad: 0.1.9 -> 0.2.1 #79409

Merged
merged 2 commits into from Feb 10, 2020
Merged

corerad: 0.1.9 -> 0.2.1 #79409

merged 2 commits into from Feb 10, 2020

Conversation

@mdlayher
Copy link
Member

@mdlayher mdlayher commented Feb 7, 2020

Motivation for this change

Version bump and minor configuration change for CoreRAD and its NixOS module test. Same ideas as my previous PR: #78034.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tests pass:

router # [   84.260566] corerad[762]: 2020/02/07 03:04:14 CoreRAD v0.2.0 (BETA) starting with configuration file "/nix/store/2sj89rv38pfp9a9zp4cbaimad3039qx9-corerad.toml"
router # [   84.716619] corerad[762]: 2020/02/07 03:04:15 eth1: "prefix": ::/64 [on-link, autonomous], preferred: 4h0m0s, valid: 24h0m0s
router # [   84.784834] corerad[762]: 2020/02/07 03:04:15 eth1: "lla": source link-layer address: 52:54:00:12:01:02
router # [   84.874558] corerad[762]: 2020/02/07 03:04:15 eth1: initialized, advertising from fe80::5054:ff:fe12:102
client: waiting for the VM to finish booting
client: connected to guest root shell
client: (connecting took 0.00 seconds)
(0.12 seconds)
client: waiting for success: ping -c 1 fd00:dead:beef:dead::1
(0.18 seconds)
(94.61 seconds)
Verify SLAAC on client
client: waiting for success: rdisc6 -1 -r 10 eth1
(0.63 seconds)
client: waiting for success: ip -6 addr show dev eth1 | grep -q 'fd00:dead:beef:dead:'
client # [   90.410541] systemd-logind[819]: New seat seat0.
client # [   90.455299] systemd-logind[819]: Watching system buttons on /dev/input/event2 (Power Button)
(0.36 seconds)
client: must succeed: ip -6 addr show dev eth1
(0.08 seconds)
2 out of 2 tests succeeded
test script finished in 97.47s
cleaning up
killing client (pid 9)
killing router (pid 21)
(0.01 seconds)
/nix/store/r30aymks0ks21v7g3hfa7q583a3ga00h-vm-test-run-unnamed

/cc @danderson @jonringer (thanks again for the reviews!)

@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Feb 7, 2020

@GrahamcOfBorg test corerad

@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Feb 7, 2020

@GrahamcOfBorg test corerad

@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Feb 7, 2020

@kalbasit thanks for the review! Fixed.

@ofborg ofborg bot requested a review from kalbasit Feb 7, 2020
@mdlayher mdlayher changed the title corerad: 0.1.9 -> 0.2.0 corerad: 0.1.9 -> 0.2.1 Feb 9, 2020
@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Feb 9, 2020

@GrahamcOfBorg test corerad

@jonringer jonringer dismissed kalbasit’s stale review Feb 9, 2020

addressed

@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Feb 9, 2020

I made some development progress in the past few days and have just bumped to 0.2.1 with a new commit. I hope that's alright, but let me know if not.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 9, 2020

more than alright, :)

Copy link
Contributor

@jonringer jonringer left a comment

do you mind squashing the commits:

corerad: 0.1.9 -> 0.2.1
nixos/corerad: update advertisement argument
@mdlayher mdlayher force-pushed the mdlayher:mdl-corerad-beta branch from 22ee92a to 9edfaf8 Feb 9, 2020
@mdlayher mdlayher force-pushed the mdlayher:mdl-corerad-beta branch from 9edfaf8 to d117114 Feb 9, 2020
@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Feb 9, 2020

@GrahamcOfBorg test corerad

@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Feb 9, 2020

I made a quick git rebase mistake but appear to have fixed it up. Thanks for the reviews!

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/79409
1 package built:
corerad
@jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 9, 2020

@jonringer jonringer merged commit 065ec9a into NixOS:master Feb 10, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
corerad on aarch64-linux Success
Details
corerad on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.corerad on aarch64-linux Success
Details
tests.corerad on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.