Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
brightnessctl: Add systemd support #79663
This makes it possible to use brightnessctl without udev rules / suid.
This should still be compatible with the existing NixOS module (but I've never used that - could somebody confirm this?) but now one can also just install
We could either enable this by default and still support the udev rules (like in this PR), drop the udev rules / NixOS module, or add a "use flag" but don't enable this by default (less recommended).
Motivation for this change
@primeos quickly skimming through
I don't really see the point adding the
The NixOS module is only adding it brightnessctl to
As the latter isn't needed anymore, I don't see much value in keeping the module - We could just notify users they only need to add the package, as logind takes care of permissions.
@flokli since the systemd-logind API is used as a fallback option it could make a difference in some special cases (e.g.
I've added a commit to remove the module (or should we deprecate it more gracefully with only a warning for now?).