Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fonts/gdouros: correct license to unfree #79679

Merged
merged 1 commit into from Feb 29, 2020

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Feb 10, 2020

Motivation for this change

I assume the licence for these fonts changed at some point, but the current licensing conditions are actually rather byzantine and definitely non-Free. They actually prohibit redistribution, so the existing Hydra builds of these packages (example) are a liability; I'm not sure who (if anyone) would be able to purge them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 10, 2020

Looks like the noncommercial requirement was added between January and March 2018; the licence forbidding redistribution first appeared in the April 20 2018 archive, so any builds on Hydra from then onwards are problematic.

@emilazy emilazy mentioned this pull request Feb 10, 2020
1 of 10 tasks complete
@ajs124
Copy link
Member

@ajs124 ajs124 commented Feb 10, 2020

Is there any statement anywhere from George Douros, the maintainer of these fonts, on this?

I found multiple other projects (arch linux, some homebrew thing, some math font thing(?)) that stumbled upon this license change, but none of the discussions had any reasoning from the guy.

While he most likely had/has some reason for this license, he might also not be aware of what this change in license means. Maybe someone should try and reach out to him to figure out if this is actually what he intended and if he might want to change the licenses again.

@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 10, 2020

I haven't found anything to that effect. I'm happy to try emailing and asking if he's considered fully free font licences, but unfortunately I doubt you go from "do anything" to "do anything noncommercial" to "do almost nothing" without intending the restrictions. If a new version under a free licence is released, that would be great, but the current package version's licence should probably be fixed until then anyway.

@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 10, 2020

@GrahamcOfBorg build aegan aegyptus akkadian assyrian eemusic maya symbola textfonts unidings

homepage = http://users.teilar.gr/~g1951d/;
hydraPlatforms = []; # redistribution not permitted

This comment has been minimized.

@yegortimoshenko

yegortimoshenko Feb 24, 2020
Member

https://hydra.nixos.org won't build unfree packages regardless of this attribute.

Copy link
Member

@yegortimoshenko yegortimoshenko left a comment

LGTM otherwise.

@yegortimoshenko
Copy link
Member

@yegortimoshenko yegortimoshenko commented Feb 27, 2020

Would like to merge this and #79681 on Feb 28 9 pm UTC. cc @grahamc

@emilazy
Copy link
Member Author

@emilazy emilazy commented Feb 29, 2020

does this need backporting to 20.03 too?

@yegortimoshenko yegortimoshenko force-pushed the emilazy:fix-gdouros-font-licenses branch from 13065b2 to 05a9b7f Feb 29, 2020
@yegortimoshenko
Copy link
Member

@yegortimoshenko yegortimoshenko commented Feb 29, 2020

does this need backporting to 20.03 too?

Actually, yes! (e.g. see #81337)

@yegortimoshenko yegortimoshenko merged commit c6c200f into NixOS:master Feb 29, 2020
@emilazy emilazy mentioned this pull request Feb 29, 2020
1 of 10 tasks complete
@emilazy emilazy deleted the emilazy:fix-gdouros-font-licenses branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.