Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libssh2-1.9.0: apply patch for CVE-2019-17498 #79740

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Feb 10, 2020

Motivation for this change

Apply patch upstream patch as there is no new release yet. According to the original advisory, this one fixes the vulnerability. Upstream PR402 is also mentioned in the CVE as patch.

Re #73662

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions -> Ubuntu
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" -> partially - tested curl with SFTP target
  • Tested execution of all binary files (usually in ./result/bin/) -> partially, see above
  • Determined the impact on package closure size (by running nix path-info -S before and after) -> minimal
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
No upstream release yet, but libssh2/libssh2#402
has been accepted by upstream devs.

Original advisory:
https://blog.semmle.com/libssh2-integer-overflow-CVE-2019-17498/

Re #73662
vcunat added a commit that referenced this pull request Feb 10, 2020
@vcunat vcunat merged commit 4682b29 into NixOS:staging Feb 10, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@FRidh
Copy link
Member

@FRidh FRidh commented Feb 10, 2020

We need to keep track that we backport this to 20.03 after branch-off.

vcunat added a commit that referenced this pull request Feb 10, 2020
(cherry picked from commit 4ff2a16)
@ckauhaus ckauhaus deleted the ckauhaus:73662-libssh2-CVE-2019-17498 branch Feb 11, 2020
vcunat added a commit that referenced this pull request Feb 12, 2020
(cherry picked from commit 4ff2a16)
@vcunat
Copy link
Member

@vcunat vcunat commented Feb 12, 2020

In staging-20.03 as 78a273d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.