Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qlandkartegt: fix broken download links #80027

Merged
merged 1 commit into from Feb 13, 2020
Merged

qlandkartegt: fix broken download links #80027

merged 1 commit into from Feb 13, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Feb 13, 2020

Motivation for this change

Source tarball is not available on Bitbucket any more, use Sourceforge instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Nothing changed
https://github.com/NixOS/nixpkgs/pull/80027
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-80027/shell.nix

@jonringer
Copy link
Contributor

builds locally as well

@jonringer jonringer merged commit 1ac4319 into NixOS:master Feb 13, 2020
@sikmir sikmir deleted the qlandkartegt branch February 13, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @jonringer