Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maven: make jdk overridable #80728

Merged
merged 1 commit into from Feb 21, 2020
Merged

maven: make jdk overridable #80728

merged 1 commit into from Feb 21, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Feb 21, 2020 •
edited

Motivation for this change

This makes it possible to use maven with different (newer) jdks.

Fixes #75630

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
maven: make jdk overridable
0141cfe 
This makes it possible to use maven with different (newer) jdks.

Fixes NixOS#75630
@timokau timokau mentioned this pull request Feb 21, 2020
Closed
@timokau timokau merged commit ec6bf45 into NixOS:master Feb 21, 2020
@timokau
Copy link
Member Author

timokau commented Feb 21, 2020

Tested locally, let nix-review run for a while. This is a simple change, should not cause any regressions.

@timokau timokau deleted the maven-jdk-overridable branch February 21, 2020 14:50
@timokau timokau mentioned this pull request Feb 21, 2020
Merged
10 tasks
@surajbarkale surajbarkale mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maven does not respect $JAVA_HOME
1 participant
@timokau