Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump discord-{ptb,canary} #81050

Merged
merged 2 commits into from Feb 25, 2020
Merged

Bump discord-{ptb,canary} #81050

merged 2 commits into from Feb 25, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 25, 2020 •
edited

Motivation for this change

follow up to #81044

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81050
2 package built:
discord-canary discord-ptb

@tadeokondrak tadeokondrak mentioned this pull request Feb 25, 2020
Closed
10 tasks
@jonringer jonringer merged commit da5e340 into NixOS:master Feb 25, 2020
@jonringer jonringer deleted the bump-discord branch February 25, 2020 20:47
kraem
kraem reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@kraem kraem left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Guess this can be closed with this merged

edit Woops. Too slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraem kraem kraem left review comments

@tadeokondrak tadeokondrak tadeokondrak approved these changes

@shyim shyim Awaiting requested review from shyim

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @tadeokondrak @kraem