vim_configurable: change python version detection #8125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A better solution than #7619 |
|
cc me |
|
Any input on this? |
| [ ./python_framework.patch ]; | ||
|
|
||
| configureFlags | ||
| = [ "--enable-gui=${args.gui}" "--with-features=${args.features}" ]; | ||
|
|
||
| nativeBuildInputs | ||
| = [ ncurses pkgconfig gtk libX11 libXext libSM libXpm libXt libXaw libXau | ||
| libXmu glib libICE ]; | ||
| = if args.gui != "no" then [ ncurses pkgconfig gtk libX11 libXext libSM libXpm libXt libXaw libXau |
There was a problem hiding this comment.
You can take out ncurses pkgconfig.
|
Complete rewrite, much simpler, no changes to X. The python3 specific stuff (python3Support, etc) was removed entirely, in favor of a simple if/else statement using |
Instead of explicitly stating "I want version 3" or "I want version 2" you now simply specify what the python argument will be, and vim_configurable will set up the flags for you. config.vim.python must be set, still.
|
Pinging @jagajaga. |
|
Hmm. What does this statement do? |
|
places a 3 if |
|
The |
|
So to enable python 3 we need to override pkg with |
|
Yes. Changing the |
jagajaga
added a commit
that referenced
this pull request
Jan 6, 2016
vim_configurable: change python version detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of explicitly stating "I want version 3" or "I want version 2"
you now simply specify what the
pythonargument will be, andvim_configurable will set up the flags for you.
config.vim.pythonmustbe set, still.
This is a complete rewrite of the PR I submitted in June 2015.
(Branch name is a bit of a misnomer, but that's the name of the package I use to test.)