Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.starlette: 0.13.0 -> 0.13.2 #81304

Closed
wants to merge 1 commit into from
Closed

python37Packages.starlette: 0.13.0 -> 0.13.2 #81304

wants to merge 1 commit into from

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Feb 28, 2020 •
edited

Motivation for this change

Update version and use fetchurl instead of fetchPypi as this is now the preferred method. This also makes the tests pass and, thus, the build, which was failing.

These changes need to backported to release-20.03, #80379

This PR will partially replace #81055

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wd15
python37Packages.starlette: 0.13.0 -> 0.13.2
9a51c3e 
In addition, use fetchurl instead of fetchPypi as this is now the
preferred method. This also makes the tests pass and, thus, the build,
which was failing.
@wd15
Copy link
Contributor Author

wd15 commented Feb 28, 2020 •
edited

Result of nix-review pr 81304 1

1 package failed to build:
  • python37Packages.fastapi
1 package were build:
  • python37Packages.starlette

Fix for fastapi is upcoming, see #81305

This was referenced Feb 28, 2020
Merged
Closed
jonringer
jonringer reviewed Feb 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill wait for #81305 to be resolved first

[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/xgyyh93amp6vz228wyqh9ddrx202innx-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/81304
1 package failed to build:
python37Packages.fastapi

1 package built:
python37Packages.starlette

@wd15
Copy link
Contributor Author

wd15 commented Feb 28, 2020

Dropping this in favor of #81305

@wd15 wd15 closed this Feb 28, 2020
@wd15 wd15 deleted the starlette-0.13.2 branch February 28, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wd15 @jonringer