Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildbot: 2.6.0 -> 2.7.0 #81406

Merged
merged 1 commit into from Feb 29, 2020
Merged

buildbot: 2.6.0 -> 2.7.0 #81406

merged 1 commit into from Feb 29, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Finishes updating buildbot after the incomplete automated update in #81283. I think this should fix the flakiness of the test on Hydra, but I can't verify it because it always passes locally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Feb 29, 2020

@GrahamcOfBorg test buildbot

@veprbl

This comment has been minimized.

Sign in to view
@veprbl veprbl added the 6.topic: testing Tooling for automated testing of packages and modules label Feb 29, 2020
veprbl
veprbl approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl merged commit 07727db into NixOS:master Feb 29, 2020
@lopsided98 lopsided98 deleted the buildbot-update branch February 29, 2020 23:24
veprbl pushed a commit to veprbl/nixpkgs that referenced this pull request Mar 8, 2020
@lopsided98 @veprbl
buildbot: 2.6.0 -> 2.7.0 (NixOS#81406)
0568be1 
(cherry picked from commit 07727db)

cc NixOS#81406
veprbl pushed a commit that referenced this pull request Mar 8, 2020
@lopsided98 @veprbl
buildbot: 2.6.0 -> 2.7.0 (#81406)
645522a 
(cherry picked from commit 07727db)

cc #81406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @veprbl