New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.scrapy: 1.8.0 -> 2.0.0 #81621
Conversation
@GrahamcOfBorg build python3Packages.scrapy |
Thank you! Poking around the repository, I found scrapy/scrapy#4356, which seems to (indirectly) refer to some of the tests that are failing. Which refers to a statement found in one of the failing tests: Though, interestingly.... it didn't mention the use of such deprecated methods in tests? Anyway, would disabling the two offending tests be enough for the time being? Tests disabled:
Relevant diffdiff --git a/pkgs/development/python-modules/scrapy/default.nix b/pkgs/development/python-modules/scrapy/default.nix
index cc22804d48a..6473cecca8b 100644
--- a/pkgs/development/python-modules/scrapy/default.nix
+++ b/pkgs/development/python-modules/scrapy/default.nix
@@ -32,7 +32,7 @@ buildPythonPackage rec {
# Ignore xml encoding test on darwin because lxml can't find encodings https://bugs.launchpad.net/lxml/+bug/707396
checkPhase = ''
substituteInPlace pytest.ini --replace "addopts = --doctest-modules" "addopts ="
- pytest --ignore=tests/test_linkextractors_deprecated.py --ignore=tests/test_proxy_connect.py --deselect tests/test_crawl.py::CrawlTestCase::test_retry_dns_error ${lib.optionalString stdenv.isDarwin "--deselect tests/test_utils_iterators.py::LxmlXmliterTestCase::test_xmliter_encoding"}
+ pytest --ignore=tests/test_linkextractors_deprecated.py --ignore=tests/test_proxy_connect.py --deselect tests/test_crawl.py::CrawlTestCase::test_retry_dns_error ${lib.optionalString stdenv.isDarwin "--deselect tests/test_utils_iterators.py::LxmlXmliterTestCase::test_xmliter_encoding --deselect tests/test_utils_gz.py::GunzipTest::test_is_x_gzipped_right --deselect tests/test_utils_http.py::ChunkedTest::test_decode_chunked_transfer"}
'';
src = fetchPypi { Seems to compile on my end. |
@GrahamcOfBorg build python3Packages.scrapy |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)