Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rkt: remove #81860

Merged
merged 1 commit into from May 16, 2020
Merged

rkt: remove #81860

merged 1 commit into from May 16, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Mar 6, 2020

rkt has basically been dead since 2018 and now upstream has made it official.

https://github.com/rkt/rkt/#warning-end-of-project-warning

This project has ended, and all development/maintenance activities have halted.

As it is free software, people are free and welcome to fork and develop the codebase on their own. However, to avoid any confusion, the original repository is archived and we recommend any further fork/development to proceed with an explicit rename and rebranding first.

We encourage all interested parties to mirror any relevant bits as we can't actively guarantee their existence in the future.

More detail in rkt/rkt#4024 (comment)

@volth
Copy link
Contributor

@volth volth commented Mar 6, 2020

Although I am not a rkt user, the reaction seems premature.
It is only 1 month since the commercial team ceased work on it.
There could be users still (the project has 9000 stars - twice as much as nixpkgs)
The community could continue development as we saw with rethinkdb after the failure of their commercial team.

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Mar 6, 2020

What is the opinion of the maintainer? @ragnard @steveeJ

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Mar 6, 2020

Also @NeQuissimus who did maintenance on the package.

@NeQuissimus
Copy link
Member

@NeQuissimus NeQuissimus commented Mar 6, 2020

All I can say is that I stopped using it :)
I would suggest keeping it around for a little while longer to see if any other entity takes over the repo. But if not, we should make sure this has been deleted for NixOS 20.09

@steveeJ
Copy link
Contributor

@steveeJ steveeJ commented Mar 6, 2020

I don't know what the policy says about packages which are unmaintained upstream. If there's no policy I suggest establishing one so these decisions are covered in the future. Personally I agree with @volth that it seems premature to removing it now. Maybe wait 2 more months?

@Infinisil
Copy link
Member

@Infinisil Infinisil commented Mar 7, 2020

On the other hand, if the software still works, has users and doesn't have glaring security vulnerabilities, I don't think there's a problem with not removing it.

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Mar 7, 2020

@Infinisil
Copy link
Member

@Infinisil Infinisil commented Mar 7, 2020

That sounds like reason enough to remove it pretty soon

@vcunat
Copy link
Member

@vcunat vcunat commented Mar 7, 2020

It is only 1 month since the commercial team ceased work on it.

The note in the ticket about dismantlement of the official team was a quotation from summer. They declared end now because "community" hasn't picked it up since then.

@vcunat
Copy link
Member

@vcunat vcunat commented Mar 7, 2020

As there are those CVEs, an alternative is to just use meta.knownVulnerabilities for now 🤷‍♂️

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Mar 7, 2020

just use meta.knownVulnerabilities for now

Opened #82023

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Mar 9, 2020

I backported the cve list to 19.09 and 20.03 as well.

@Valodim
Copy link
Contributor

@Valodim Valodim commented Mar 25, 2020

This issue is handled as discussed by #82023. Might as well close this, and revisit for 20.09.

@Mic92 Mic92 added this to the 20.09 milestone Mar 25, 2020
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Mar 25, 2020

We can also just keep this open for 20.09 as a milestone.

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented May 14, 2020

Are there any news about a new fork of rkt?

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented May 15, 2020

I couldn't find anything.

Also added a comment to the release notes for 2009.

@Mic92 Mic92 merged commit 3233d3f into NixOS:master May 16, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5195aed"; rev="5195aed6171249a830c95401a88687bac4eb7193"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5195aed"; rev="5195aed6171249a830c95401a88687bac4eb7193"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5195aed"; rev="5195aed6171249a830c95401a88687bac4eb7193"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5195aed"; rev="5195aed6171249a830c95401a88687bac4eb7193"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5195aed"; rev="5195aed6171249a830c95401a88687bac4eb7193"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5195aed"; rev="5195aed6171249a830c95401a88687bac4eb7193"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5195aed"; rev="5195aed6171249a830c95401a88687bac4eb7193"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:rm-rkt branch May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.