Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage: fix test suite with docutils 0.15 #82240

Merged
merged 1 commit into from Mar 10, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 10, 2020

Motivation for this change

The better way to fix this would be to backport the upstream sphinx
patch:

sphinx-doc/sphinx@faedcc4

Unfortunately it doesn't apply cleanly and isn't worth the effort
of backporting. Let's hope we can switch to python3 sage and the recent
sphinx version that comes with it before this becomes a problem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The better way to fix this would be to backport the upstream sphinx
patch:

sphinx-doc/sphinx@faedcc4

Unfortunately it doesn't apply cleanly and isn't worth the effort
of backporting. Let's hope we can switch to python3 sage and the recent
sphinx version that comes with it before this becomes a problem.
@timokau
Copy link
Member Author

timokau commented Mar 10, 2020

Note that this will only fix half of #81449, with the other half being covered in #82239. I separated the two because #82239 touches a different package.

@timokau timokau merged commit e05e219 into NixOS:master Mar 10, 2020
@timokau timokau deleted the sage-docutils-0.15-fix branch March 10, 2020 15:25
@timokau timokau mentioned this pull request Mar 10, 2020
fusion809 added a commit to fusion809/nixpkgs that referenced this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant