Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texworks: fix build #82873

Merged
merged 2 commits into from Mar 18, 2020
Merged

texworks: fix build #82873

merged 2 commits into from Mar 18, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Mar 18, 2020 •
edited

Motivation for this change

closes #82844

gui now opens fine

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/82873
1 package built:
texworks

@ofborg ofborg bot requested a review from dotlambda March 18, 2020 20:04
@jonringer
Copy link
Contributor Author

fixes broken application

@jonringer jonringer merged commit aaefb94 into NixOS:master Mar 18, 2020
@jonringer jonringer deleted the fix-texworks branch March 18, 2020 22:59
@bhipple
Copy link
Contributor

bhipple commented Mar 19, 2020

Backport to 20.03 for ZHF?

@jonringer
Copy link
Contributor Author

oh, that would probably be a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @bhipple @r-ryantm