Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpactor: init at 0.14.1 #83045

Closed
wants to merge 1 commit into from
Closed

phpactor: init at 0.14.1 #83045

wants to merge 1 commit into from

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 21, 2020

Motivation for this change

Creates a basic package for phpactor using composer2nix. phpactor is a completion, refactoring and introspection tool for PHP codebases and can be used e.g. with deoplete-phpactor like this:

with import ./. { };

let p = neovim.override {
  configure.vam = {
    knownPlugins = pkgs.vimPlugins;
    pluginDictionaries = [
      { name = "deoplete-nvim"; }
      { name = "deoplete-phpactor"; }
    ];
  };
  configure.customRC = ''
    let g:deoplete#enable_at_startup = 1
    let g:phpactorPhpBin = '${php}/bin/php'
    let g:deoplete#auto_complete_delay=120
    let &runtimepath.=',${phpPackages.phpactor}'
  '';
}; in
  symlinkJoin {
    name = "phptest";
    paths = [ p ];
    nativeBuildInputs = [ makeWrapper ];
    postBuild = ''
      wrapProgram $out/bin/nvim \
        --prefix PATH : "${phpPackages.phpactor}/bin"
    '';
  }

Things to be fixed before merging:

  • $out/bin contains additional executables like composer that should be removed
  • Pin phpactor version in pkgs/development/interpreters/php/packages/phpactor/composer.json rather than using a wildcard.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@globin
Copy link
Member

@globin globin commented Apr 19, 2020

Conflicting with master

@Ma27 Ma27 marked this pull request as draft Jun 16, 2020
@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Jun 16, 2020

Converted to a draft now, this needs more work to get this merged.

@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Oct 17, 2020

Closing. Not interested in working on that anymore.

@Ma27 Ma27 closed this Oct 17, 2020
@Ma27 Ma27 deleted the phpactor branch Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants