Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipboard-indicator: removed broken flag. #83088

Merged
merged 1 commit into from Apr 9, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Mar 21, 2020

Motivation for this change

This gnome3 extension still works with gnome3.34, making the broken flag unnecessary.

Things done

Removed the traces that made the extension broken and uninstallable via normal ways.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    cc @jonafato

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Mar 21, 2020
@lasandell
Copy link
Contributor

I tested this and did not find any issues. The upstream repo has added 3.34 to the supported versions in the extension's metadata.json, but there is no later version tag than the v30 tag we already reference. I vote to merge it.

@dasj19
Copy link
Contributor Author

dasj19 commented Mar 30, 2020

@GrahamcOfBorg build gnomeExtensions.clipboard-indicator

@dasj19
Copy link
Contributor Author

dasj19 commented Apr 1, 2020

@hedning, @jtojnar can we get this small gnome-related change approved?

@hedning
Copy link
Contributor

hedning commented Apr 1, 2020

Right, seems to work with 3.36 too, so seems good to me: Tudmotu/gnome-shell-extension-clipboard-indicator#201

@hedning hedning merged commit 4755186 into NixOS:master Apr 9, 2020
bjornfor pushed a commit that referenced this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants