-
-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "nixos-container: use systemd-run instead of nsenter" #83392
Revert "nixos-container: use systemd-run instead of nsenter" #83392
Conversation
This reverts commit 7cb100b. This appears to break at least the `container`-backend of `nixops`: when running `switch-to-configuration` within `nixos-container run`, the running `systemd`-instance gets reloaded which appears to kill the `systemd-run` command and causes `nixos-container run` to hang. The full issue is reported in the original PR[1]. [1] NixOS#67332 (comment)
Tests are passing locally as well 🎉 @GrahamcOfBorg test containers-imperative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be safe to revert since we don't have support for unprivileged containers yet anyway. Thanks for looking into it!
lgtm |
@Ma27 Is there a PR for master with this as well? If we don't do that it's less likely it will be fixed. (I did read your header) |
I would've opened a tracking issue to fix it properly. Or do you prefer a revert for master as well? |
I'd actually say both since we should be using systemd-run eventually. |
Motivation for this change
release-20.03
for now to get rid of the regression within thecontainer
-backend ofnixops
. After merging this, an issue should be opened to track further changes (to use the original commit without further regressions on 20.09).This reverts commit 7cb100b.
This appears to break at least the
container
-backend ofnixops
: whenrunning
switch-to-configuration
withinnixos-container run
, therunning
systemd
-instance gets reloaded which appears to kill thesystemd-run
command and causesnixos-container run
to hang.The full issue is reported in the original PR[1].
[1] #67332 (comment)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)