dgedit: init at 0.10.0 #83597

matthiasbeyer · 2020-03-28T14:31:29Z

Motivation for this change

Things done

puzzlewolf

Doesn't work for me:

[nix-shell:~/.cache/nixpkgs-review/pr-83597]$ ./results/dgedit/bin/dgedit 
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)

Perhaps a missing qt dependency?

matthiasbeyer · 2020-03-29T10:42:10Z

Oh, yeah, I did not finish this...

matthiasbeyer · 2020-03-29T10:58:04Z

So, as far as I can see, this is built withg qt4. I still get the following error:

qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

And a segfault afterwards. But I am not sure whether this is due that I run wayland and sway and whether it would work on x11...

jonringer

otherwise LGTM

pkgs/applications/audio/dgedit/default.nix

matthiasbeyer · 2020-03-31T19:35:09Z

Ready to rebase?

jonringer

doesn't build for me

builder for '/nix/store/6vvwnrfrlzk2qlvv00rcqy4i6jx8mymq-dgedit.drv' failed with exit code 1; last 10 log lines:
  fatal: unable to connect to git.drumgizmo.org:
  git.drumgizmo.org[0: 212.178.176.2]: errno=Connection refused

  fatal: unable to connect to git.drumgizmo.org:
  git.drumgizmo.org[0: 212.178.176.2]: errno=Connection refused

  fatal: unable to connect to git.drumgizmo.org:
  git.drumgizmo.org[0: 212.178.176.2]: errno=Connection refused

  Unable to checkout refs/tags/v0.10.0 from git://git.drumgizmo.org/dgedit.git/.

jonringer

please fix:

$ ./results/dgedit/bin/dgedit
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)

https://nixos.org/nixpkgs/manual/#sec-language-qt

puzzlewolf · 2020-04-14T12:22:21Z

The binary works on X for me now :)

puzzlewolf · 2020-04-14T12:52:02Z

pkgs/applications/audio/dgedit/default.nix

+  meta = with stdenv.lib; {
+    description = "the DrumGizmo drumkit editor";
+    homepage = "https://drumgizmo.org/";
+    license = licenses.gpl3Plus;


The licensing situation of this project seems a bit mixed. The program (menu Help/about/License) displays a GPL 3, calls it GPL (without version number), but the source files say "GPL version 2 or later" 😕. Obviously, GPL 3 is included in "or later". I don't know what we should do here, maybe ask upstream to clarify? Is this actually a problem?

Clearification would be nice, yes.

pkgs/applications/audio/dgedit/default.nix

stale · 2020-10-11T14:03:02Z

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

pkgs/applications/audio/dgedit/default.nix

SuperSandro2000 · 2020-11-27T21:56:09Z

Result of nixpkgs-review pr 83597 run on x86_64-linux 1

1 package built:

dgedit

matthiasbeyer · 2020-11-28T19:03:55Z

Nice, thanks.
Btw: LOL github... does not even make the default commit message a real fixup message. 😠

SuperSandro2000

Can you squash the commits?

SuperSandro2000 · 2020-12-27T23:33:34Z

Result of nixpkgs-review pr 83597 run on x86_64-linux 1

1 package built:

dgedit

matthiasbeyer · 2020-12-28T10:45:26Z

Done

pkgs/applications/audio/dgedit/default.nix

SuperSandro2000

diff LGTM. Can someone with X11 confirm that it does not segfault?

pkgs/applications/audio/dgedit/default.nix

siraben · 2021-01-15T01:05:35Z

Build succeeds on darwin but fails at runtime.

make[1]: Entering directory '/private/tmp/nix-build-dgedit-0.10.0.drv-0/dgedit'
make[2]: Entering directory '/private/tmp/nix-build-dgedit-0.10.0.drv-0/dgedit'
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-dgedit-0.10.0.drv-0/dgedit'
make[1]: Leaving directory '/private/tmp/nix-build-dgedit-0.10.0.drv-0/dgedit'
qtOwnPathsHook
post-installation fixup
wrapping Qt applications in /nix/store/wazwcnh64pcccnrblz92bn2gk8wqa29i-dgedit-0.10.0/bin /nix/store/wazwcnh64pcccnrblz92bn2gk8wqa29i-dgedit-0.10.0/sbin /nix/store/wazwcnh64pcccnrblz92bn2gk8wqa29i-dgedit-0.10.0/libexec
strip is /nix/store/ynbk6s6nqmrvv17snwydkfn64h81r4yv-cctools-binutils-darwin-949.0.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wazwcnh64pcccnrblz92bn2gk8wqa29i-dgedit-0.10.0/bin 
patching script interpreter paths in /nix/store/wazwcnh64pcccnrblz92bn2gk8wqa29i-dgedit-0.10.0
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/wazwcnh64pcccnrblz92bn2gk8wqa29i-dgedit-0.10.0
qt.qpa.plugin: Could not find the Qt platform plugin "cocoa" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

[1]    47483 abort      ./result/bin/dgedit

Looks like it could be a trivial fix.

SuperSandro2000 · 2021-01-15T15:18:43Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 83597 run on x86_64-linux 1

1 package built:

dgedit

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Mar 28, 2020

puzzlewolf suggested changes Mar 29, 2020

View reviewed changes

jonringer reviewed Mar 31, 2020

View reviewed changes

pkgs/applications/audio/dgedit/default.nix Outdated Show resolved Hide resolved

pkgs/applications/audio/dgedit/default.nix Outdated Show resolved Hide resolved

jonringer reviewed Mar 31, 2020

View reviewed changes

pkgs/applications/audio/dgedit/default.nix Show resolved Hide resolved

jonringer suggested changes Mar 31, 2020

View reviewed changes

matthiasbeyer force-pushed the add-dgedit branch from 1ad342f to bce5ed7 Compare April 5, 2020 13:03

jonringer suggested changes Apr 13, 2020

View reviewed changes

matthiasbeyer force-pushed the add-dgedit branch from bce5ed7 to c865f54 Compare April 14, 2020 07:16

ofborg bot added the 10.rebuild-linux: 1 label Apr 14, 2020

puzzlewolf suggested changes Apr 14, 2020

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 11, 2020

SuperSandro2000 requested changes Nov 27, 2020

View reviewed changes

pkgs/applications/audio/dgedit/default.nix Outdated Show resolved Hide resolved

pkgs/applications/audio/dgedit/default.nix Outdated Show resolved Hide resolved

stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Nov 27, 2020

SuperSandro2000 reviewed Dec 27, 2020

View reviewed changes

matthiasbeyer force-pushed the add-dgedit branch from 78bd00a to 05cf473 Compare December 28, 2020 10:45

SuperSandro2000 reviewed Jan 11, 2021

View reviewed changes

pkgs/applications/audio/dgedit/default.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Jan 11, 2021

View reviewed changes

pkgs/applications/audio/dgedit/default.nix Show resolved Hide resolved

matthiasbeyer force-pushed the add-dgedit branch from 36a0ff2 to 4f68485 Compare January 11, 2021 20:18

SuperSandro2000 reviewed Jan 12, 2021

View reviewed changes

pkgs/applications/audio/dgedit/default.nix Outdated Show resolved Hide resolved

matthiasbeyer force-pushed the add-dgedit branch from 7a9410c to 51a25c8 Compare January 12, 2021 15:24

SuperSandro2000 approved these changes Jan 13, 2021

View reviewed changes

siraben requested changes Jan 14, 2021

View reviewed changes

pkgs/applications/audio/dgedit/default.nix Show resolved Hide resolved

dgedit: init at 0.10.0

edd795c

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

matthiasbeyer force-pushed the add-dgedit branch from 47ca1d6 to edd795c Compare February 1, 2021 14:33

matthiasbeyer closed this Apr 13, 2021

matthiasbeyer deleted the add-dgedit branch April 13, 2021 11:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dgedit: init at 0.10.0 #83597

dgedit: init at 0.10.0 #83597

matthiasbeyer commented Mar 28, 2020

puzzlewolf left a comment

matthiasbeyer commented Mar 29, 2020

matthiasbeyer commented Mar 29, 2020

jonringer left a comment

matthiasbeyer commented Mar 31, 2020

jonringer left a comment •

edited

jonringer left a comment

puzzlewolf commented Apr 14, 2020

puzzlewolf Apr 14, 2020

matthiasbeyer Apr 14, 2020

stale bot commented Oct 11, 2020

SuperSandro2000 commented Nov 27, 2020

matthiasbeyer commented Nov 28, 2020

SuperSandro2000 left a comment

SuperSandro2000 commented Dec 27, 2020

matthiasbeyer commented Dec 28, 2020

SuperSandro2000 left a comment

siraben commented Jan 15, 2021 •

edited

SuperSandro2000 commented Jan 15, 2021

dgedit: init at 0.10.0 #83597

dgedit: init at 0.10.0 #83597

Conversation

matthiasbeyer commented Mar 28, 2020

Motivation for this change

Things done

puzzlewolf left a comment

Choose a reason for hiding this comment

matthiasbeyer commented Mar 29, 2020

matthiasbeyer commented Mar 29, 2020

jonringer left a comment

Choose a reason for hiding this comment

matthiasbeyer commented Mar 31, 2020

jonringer left a comment • edited

Choose a reason for hiding this comment

jonringer left a comment

Choose a reason for hiding this comment

puzzlewolf commented Apr 14, 2020

puzzlewolf Apr 14, 2020

Choose a reason for hiding this comment

matthiasbeyer Apr 14, 2020

Choose a reason for hiding this comment

stale bot commented Oct 11, 2020

SuperSandro2000 commented Nov 27, 2020

matthiasbeyer commented Nov 28, 2020

SuperSandro2000 left a comment

Choose a reason for hiding this comment

SuperSandro2000 commented Dec 27, 2020

matthiasbeyer commented Dec 28, 2020

SuperSandro2000 left a comment

Choose a reason for hiding this comment

siraben commented Jan 15, 2021 • edited

SuperSandro2000 commented Jan 15, 2021

jonringer left a comment •

edited

siraben commented Jan 15, 2021 •

edited