Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpc: 3.0.0 -> 3.0.4; lazarus: 1.8.4 -> 2.0.6 #84033

Merged
merged 1 commit into from Apr 2, 2020

Conversation

utsl42
Copy link
Contributor

@utsl42 utsl42 commented Apr 1, 2020

Motivation for this change

Upgrading very old FreePascal and Lazarus packages

Things done

Only tested on x86_64. Did not run Lazarus (don't have a system running X at the moment). Did do a reverse dependencies build.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

NOTE: hedgewars failed to build, matching a failure mentioned in #73829

  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c April 1, 2020 20:57
@7c6f434c 7c6f434c merged commit c743242 into NixOS:master Apr 2, 2020
@utsl42 utsl42 deleted the fpc-upgrade branch April 2, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants