Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catcli: init at 0.5.13 #84078

Merged
merged 2 commits into from Apr 11, 2020
Merged

catcli: init at 0.5.13 #84078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f5a97b
maintainers-list: add petersjt014
petersjt014 Apr 2, 2020
aa84e47
catcli: init at 0.5.13
petersjt014 Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions maintainers/maintainer-list.nix
View file
Open in desktop
Expand Up @@ -5741,6 +5741,12 @@
githubId = 5515707;
name = "Peter Romfeld";
};
petersjt014 = {
email = "petersjt014@gmail.com";
github = "petersjt014";
githubId = 29493551;
name = "Josh Peters";
};
peti = {
email = "simons@cryp.to";
github = "peti";
Expand Down
30 changes: 30 additions & 0 deletions pkgs/tools/filesystems/catcli/default.nix
View file
Open in desktop
@@ -0,0 +1,30 @@
{ stdenv
, fetchFromGitHub
, buildPythonApplication
, docopt, anytree
}:

buildPythonApplication rec {

pname = "catcli";
version = "0.5.13";

src = fetchFromGitHub {
owner = "deadc0de6";
repo = pname;
rev = "v${version}";
sha256 = "04mrkqmm2c8fhi1h1hddc4yh3dqhcvkmcwzhj0ggn34v7wavgb5i";
};

propagatedBuildInputs = [ docopt anytree ];

postPatch = '' patchShebangs . '';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what necessitated this?
it seems to work without it (though i am not familiar with this tool)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's where I was pointed to when I asked. Apparently it's recommended to catch subtle path-related bugs (which could come up later if new deps are introduced). I don't think it's doing much now but it's also not harming anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fixupPhase already does this
going by the fact that without this line the wrapped script has a shebang to python in the nix store, i'm guessing it also runs for buildPythonApplication


meta = with stdenv.lib; {
description = "The command line catalog tool for your offline data";
homepage = "https://github.com/deadc0de6/catcli";
license = licenses.gpl3;
maintainers = with maintainers; [ petersjt014 ];
platforms = platforms.linux;
};
}
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
View file
Open in desktop
Expand Up @@ -830,6 +830,8 @@ in

certigo = callPackage ../tools/admin/certigo { };

catcli = python3Packages.callPackage ../tools/filesystems/catcli { };

chezmoi = callPackage ../tools/misc/chezmoi { };

chipsec = callPackage ../tools/security/chipsec {
Expand Down