Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k3s: fix https://hydra.nixos.org/build/116132269 #84369

Merged
merged 1 commit into from Apr 5, 2020
Merged

k3s: fix https://hydra.nixos.org/build/116132269 #84369

merged 1 commit into from Apr 5, 2020

Conversation

cleverca22
Copy link
Contributor

Motivation for this change

https://hydra.nixos.org/build/116132269 was failing

Things done

removed the with import <nixpkgs>{};

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cleverca22 cleverca22 mentioned this pull request Apr 5, 2020
Merged
10 tasks
euank
euank approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, thanks, I'm new to writing nix derivations and didn't realize I couldn't use with import <nixpkgs> {} for nixpkgs.

@grahamc grahamc merged commit be353eb into NixOS:master Apr 5, 2020
@grahamc grahamc mentioned this pull request Apr 5, 2020
Closed
@cleverca22 cleverca22 deleted the fix-k3s branch April 6, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euank euank euank approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cleverca22 @euank @grahamc