Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ssh: don't accept ssh-dss keys #84602

Merged
merged 1 commit into from
Apr 10, 2020
Merged

nixos/ssh: don't accept ssh-dss keys #84602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 2 additions & 7 deletions nixos/modules/programs/ssh.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,9 @@ in
'';
};

# Allow DSA keys for now. (These were deprecated in OpenSSH 7.0.)
pubkeyAcceptedKeyTypes = mkOption {
type = types.listOf types.str;
default = [
"+ssh-dss"
];
default = [];
example = [ "ssh-ed25519" "ssh-rsa" ];
description = ''
Specifies the key types that will be used for public key authentication.
Expand All @@ -75,9 +72,7 @@ in

hostKeyAlgorithms = mkOption {
type = types.listOf types.str;
default = [
"+ssh-dss"
Mic92 marked this conversation as resolved.
Show resolved Hide resolved
];
default = [];
example = [ "ssh-ed25519" "ssh-rsa" ];
description = ''
Specifies the host key algorithms that the client wants to use in order of preference.
Expand Down