Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevo: init at 0.2 #85040

Merged
merged 3 commits into from Oct 8, 2020
Merged

prevo: init at 0.2 #85040

merged 3 commits into from Oct 8, 2020

Conversation

@das-g
Copy link
Member

@das-g das-g commented Apr 11, 2020

Motivation for this change

Make prevo (CLI offline version of the Esperanto online dictionary ReVo) available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@CloudArtAdmins
Copy link
Contributor

@CloudArtAdmins CloudArtAdmins commented Apr 12, 2020

This built, binary works, not sure how to select language for testing, though.

@das-g
Copy link
Member Author

@das-g das-g commented Apr 12, 2020

not sure how to select language for testing, though.

To look up an Esperanto word, enter it as the fist argument to prevo:

prevo malsanulejo

To look up a possible Esperanto translation for a non-Esperanto word, pass the two-letter language code as first argument and the word as the second argument:

prevo en hospital
prevo de Krankenhaus

@CloudArtAdmins
Copy link
Contributor

@CloudArtAdmins CloudArtAdmins commented Apr 12, 2020

Gave it a try.
Yeah, that works. Tried a few words on it.
Spanish and English functioned, so I think it works.

@das-g
Copy link
Member Author

@das-g das-g commented May 2, 2020

I wonder whether me implementing this as three packages is the right approach:

  • package prevo-tools provides

    • the executable prevodb to pre-process the dictionary data
    • the executable prevo to query the dictionary (requiring the pre-processed data)

    They're build from the same source code repo and have a relation similar to the one between updatedb and locate.

  • package prevo-data provides the pre-processed dictionary data (using prevodb from prevo-tools at build-time)

  • package prevo links the other two packages together, so that the prevo command will use the data from prevo-data by default. (Can be overridden by a command line option.)

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented May 2, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/155

@das-g
Copy link
Member Author

@das-g das-g commented Jun 11, 2020

Result of nixpkgs-review pr 85040 1

3 packages built:
- prevo
- prevo-data
- prevo-tools

pkgs/applications/misc/prevo/tools.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
@ryantm
Copy link
Member

@ryantm ryantm commented Oct 8, 2020

Result of nixpkgs-review pr 85040 1

3 packages built:
- prevo
- prevo-data
- prevo-tools

@ryantm
Copy link
Member

@ryantm ryantm commented Oct 8, 2020

Result of nixpkgs-review pr 85040 1

3 packages built:
- prevo
- prevo-data
- prevo-tools

@ryantm ryantm merged commit c6a937e into NixOS:master Oct 8, 2020
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants