Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.asn1-types: backport 0.3.3 -> 0.3.4 #85759

Merged
merged 1 commit into from Apr 22, 2020
Merged

haskellPackages.asn1-types: backport 0.3.3 -> 0.3.4 #85759

merged 1 commit into from Apr 22, 2020

Conversation

schmittlauch
Copy link
Member

backports the fix for vincenthz/hs-asn1#35

(cherry picked from commit cb0e381)

continuation of #85754

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch
haskellPackages.asn1-types: backport 0.3.3 -> 0.3.4
e3d36b6 
backports the fix for vincenthz/hs-asn1#35

(cherry picked from commit cb0e381)
@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build haskellPackages.asn1-types

@cdepillabout
Copy link
Member

Builds at least on Linux, so it looks good to me.

@schmittlauch Thanks!

@cdepillabout cdepillabout merged commit 8b5004f into NixOS:staging-20.03 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schmittlauch @cdepillabout