Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apostrophe: add alias from uberwriter #85881

Merged
merged 1 commit into from Apr 29, 2020
Merged

Conversation

@sternenseemann
Copy link
Member

sternenseemann commented Apr 23, 2020

Motivation for this change

The package is part of NixOS 20.03 as pkgs.uberwriter, so the rename to Apostrophe might be confusing for some users, when the change is incorporated into a NixOS release. This alias eases future transition.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The pkg is part of NixOS 20.03 as pkgs.uberwriter, so the rename
to apostrophe might be confusing for some users.
@sternenseemann
Copy link
Member Author

sternenseemann commented Apr 24, 2020

@GrahamcOfBorg build uberwriter

@sternenseemann
Copy link
Member Author

sternenseemann commented Apr 28, 2020

@Mic92 Do you think this is worth doing now?

@Mic92 Mic92 merged commit 9ae6b51 into NixOS:master Apr 29, 2020
17 checks passed
17 checks passed
apostrophe, apostrophe.passthru.tests on aarch64-linux No attempt
Details
uberwriter on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
apostrophe, apostrophe.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f56d35"; rev="9f56d3509c779572fb9546b4757f414ce0578ebd"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f56d35"; rev="9f56d3509c779572fb9546b4757f414ce0578ebd"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f56d35"; rev="9f56d3509c779572fb9546b4757f414ce0578ebd"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f56d35"; rev="9f56d3509c779572fb9546b4757f414ce0578ebd"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f56d35"; rev="9f56d3509c779572fb9546b4757f414ce0578ebd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f56d35"; rev="9f56d3509c779572fb9546b4757f414ce0578ebd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f56d35"; rev="9f56d3509c779572fb9546b4757f414ce0578ebd"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
uberwriter on x86_64-linux Success
Details
@sternenseemann sternenseemann deleted the sternenseemann:apostrophe-alias branch Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.