Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome3.updateScript: Add freeze functionality #85968

Merged
merged 2 commits into from Apr 24, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 24, 2020

Motivation for this change

On stable releases, we will want to change the freeze parameter in pkgs/desktops/gnome-3/update.nix to true to limit the gnome update script to only bump patch versions.

Things done
  • Tested on release-20.03 branch with freeze = true
  • Tested on master branch

cc @worldofpeace @hedning

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 24, 2020
worldofpeace
worldofpeace previously approved these changes Apr 24, 2020
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, could you run find-latest-version.py through black?

@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 24, 2020

Cool.

So now we get an error: list index 1 is out of bounds out of bounds error at lib.versions.minor

@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 24, 2020

libgudev?

@worldofpeace
Copy link
Contributor

libgudev?

Yes, that attribute gives out of bounds because its version 233

On stable releases, we will want to change the freeze parameter in pkgs/desktops/gnome-3/update.nix
to true to limit the gnome update script to only bump patch versions.
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran update.nix on gnome3 attribute on master without frozen without a problem ✔️
I ran update.nix on gnome3 attribute on release-20.03 without a problem,
and packages were updated in the proper bound ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants