New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux-rock64: kernel for Rock64 and RockPro64 systems #86007
Conversation
@samueldr is likely to have an opinion on this. |
I can also test this as I have the hardware. |
@prusnak I tried to respond to you on IRC, but you weren't online I don't know what the PCIe issue is, other than that it is known to be finicky. I'm not really sure I want my kernel to be included in an official capacity in nixpkgs, since I sometimes don't update it for months at a time. I particularly don't want the 4.19 branch to be included since I haven't updated it for a long time and I no longer use it. I think this may be more appropriate for the nixos-hardware repository. |
@lopsided98 Fair enough - we can try to use the kernel directly from the ayufan-rock64/linux-kernel repo (that's what armbian is using and I saw no problems with PCIe there either). I had trouble compiling it against the current nixpkgs master, though. |
I believe you have to pass You might also want to try https://github.com/ayufan-rock64/linux-mainline-kernel (which my repo is based on) in the off chance that I left out one of the patches that makes PCIe work. |
If I can find an unused PCIe device lying around, I'll try to reproduce the problem as well. |
I just tried |
I reworked the PR to not include kernel 4.19.y from lopsided98, but rather to use the latest tagged release in Tested on my RockPro64 and even the PCIe works fine. |
I have a 5.5 kernel on my github that works. I can also upload my nixpkgs tree for that board that includes an expression to build an Image. it's hard for me to keep the kernel up to date with what's in master though, and it includes an overclock to 2.2/1.7 which may require fan cooling. Although it's a fairly popular board, I think we can get into a mess if we start officially supporting lots of forked kernels of various versions for every come-and-go SBC out there. |
Does it work with PCIe as well?
I think this could be moved to the |
@prusnak Yes I've been running root from a pcie nvme drive for months ( kernel/initrd on SD card ). Using Panfrost on mesa-git, I'm running pantheon DE with no problems as well. There may be a minor version patch in my nixpkgs that isn't applied to my kernel fork, but I've been running 5.5.7 specifically for some time now. Major version patches don't apply cleanly and need a bit of manual intervention. The nixos-hardware repo does seems like it might be a fitting place for it. |
Will close this PR and create another one to the nixos-hardware repo. |
Motivation for this change
This PR adds kernel for Rock64 and RockPro64 systems.
I tried to use 5.4.y and 5.6.y both vanilla and from @lopsided98 repo, but they end up with PCIe issues on my RockPro64:
Kernel 4.19.y does not have this issue.
I'd like to provide
sd-image-rock64.nix
in a further PR to allow easy build of SD images for these systems.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)